week numbers

[WickyNilliams]

• adds show-week-numbers option to date/range/multi components
• adds weeknumber slot to month component
• adds <col>s plus css parts for each column in month
• adds weekday part for day headings, weeknumber part for week number heading

Todo

• test how week numbers are announced in SRs

[raphaelokon]

@WickyNilliams Hi there. Is there anything we could help with to get the show-week-numbers feature released? Cheers for the great component btw.

[WickyNilliams]

I just need to merge and release really. Not sure why I didn't at the time, since the feature is complete.

I haven't had much time recently as I've had a lot going on. But I'm planning on putting some hours in later this week. I'll ping you when it's released :)

In the meanwhile, feel free to take a look at the code and give any feedback!

[raphaelokon]

Thanks @WickyNilliams

I already did! Looks really good, it is a breeze to use Cally.

[raphaelokon]

@WickyNilliams One thing that might be a tricky one is that if the week-numbers are structurally part of the table, they will be part of the navigation of assistive technologies like NVDA and VoiceOver. Since the week-numbers do not take part in the date selection process this might confuse screenreader users. What do you think?

[WickyNilliams]

It should announce "30th December, Monday, week 52" (order may not be correct, I'm going from memory), which I think is fine?

The week will only be announced when you change week (move focus vertically). Similar to how day is only announced when you change day (move focus horizontally). So it shouldn't be overly noisy. If you have chosen to show the week number, it feels like you'd want this announced else why show the week number?

[raphaelokon]

That sounds reasonable. I just wanted to make the point that if the week-numbers are part of the table, the table could be announced with one additional columnwhich might confuse the user. This is just wild guessing tho as I do not have the rendered markup in front of me.

[WickyNilliams]

Ah I see what you mean. The week number cells are configured as headers, rather than a regular cell. So I hope it should be clear, especially if devs give a reasonable title to the column.

I'll make sure to do some additional screen reader testing before merge

[raphaelokon]

This is a bit off-topic, but related to weeks → Do you think it would be feasible to let the shortDayName be configurable between 'narrow' | 'short'? → https://github.com/WickyNilliams/cally/blob/main/src/calendar-month/useCalendarMonth.ts#L21

[WickyNilliams]

following up: I made some tweaks over the weekend to improve how weeks get announced. I need to do more testing with various screen readers to see how they all fare

[WickyNilliams]

@raphaelokon that might be nice, can you create a new issue for that

[raphaelokon]

@WickyNilliams → #66

[raphaelokon]

@WickyNilliams Do you need any testing help with the week-numbers? I also created an issue re configuring the weekname abbreviation.