GH Actions: fix fixer conflict check #2243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream PR squizlabs/PHP_CodeSniffer#3833 is part of the fixes needed for this. I have another few lined up. Not finished yet though. |
|
Upstream PR PHPCSStandards/PHPCSUtils#476, which is included in the PHPCSUtils 1.0.6 release, is part of the fixes needed for this. |
This was referenced May 27, 2023
While checking something else, I came across a notice in the GH Actions logs showing that the fixer conflict check was failing. Some backtracing shows that it has been failing for the past five months since PR 2132 was merged - see: https://github.com/WordPress/WordPress-Coding-Standards/actions/runs/3643130487 Unfortunately, the way the script was set up, this failure was not showing and not failing the builds. The changes I'm proposing now will fix that. I've also made sure that once the current fixer conflicts are fixed, the build will properly succeed again: https://github.com/jrfnl/WordPress-Coding-Standards/actions/runs/5048089688/jobs/9055836148 Next up: fix the fixer conflicts and whatever other errors have crept in since the build originally started failing....
jrfnl
force-pushed
the
feature/ghactions-fail-build-on-fixer-conflicts
branch
from
08913ba to
96b0494
Compare
…ict check ... until upstream PR squizlabs/PHP_CodeSniffer 3833 has been merged. This will allow for the fixer conflict check to be enabled again already and to prevent new issues from being introduced.
|
I've added a second commit to temporarily ignore one test case file until an upstream PR has been merged. At least that allows us to turn the check back on and prevent new issues from getting into the codebase unnoticed. Marking this PR "ready for review". |
dingo-d
approved these changes
May 29, 2023
2 tasks
|
I've opened issue #2274 as a reminder to remove the test exclusion as soon as we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While checking something else, I came across a notice in the GH Actions logs showing that the fixer conflict check was failing.
Some backtracing shows that it has been failing for the past five months since PR #2132 was merged - see: https://github.com/WordPress/WordPress-Coding-Standards/actions/runs/3643130487
Unfortunately, the way the script was set up, this failure was not showing and not failing the builds. /cc @desrosj
The changes I'm proposing now will fix that.
I've also made sure that once the current fixer conflicts are fixed, the build will properly succeed again: https://github.com/jrfnl/WordPress-Coding-Standards/actions/runs/5048089688/jobs/9055836148
Next up: fix the fixer conflicts and whatever other errors have crept in since the build originally started failing....
GH Actions: temporarily ignore one test case file for the fixer conflict check
... until upstream PR squizlabs/PHP_CodeSniffer#3833 has been merged.
This will allow for the fixer conflict check to be enabled again already and to prevent new issues from being introduced.