Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Create Block Theme plugin step with shortcut #83

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

zaerl
Copy link

@zaerl zaerl commented Dec 2, 2024

Fix: #49

Replace Create Block Theme plugin step with shortcut.

Replace Create Block Theme plugin step with shortcut.
Copy link

github-actions bot commented Dec 2, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@zaerl
Copy link
Author

zaerl commented Dec 2, 2024

@bph I made the change suggested on #49. Let me know what you think.

@zaerl zaerl changed the title Update blueprint.json Replace Create Block Theme plugin step with shortcut Dec 2, 2024
@zaerl zaerl self-assigned this Dec 2, 2024
@zaerl zaerl requested a review from a team December 2, 2024 11:54
@bph
Copy link
Collaborator

bph commented Dec 2, 2024

Awesome. Thank you. @zaerl
You also replaced the steps, I saw. Seems earlier updated reduced the number of plugins to one. Or I don't remember that I was thinking with this: "plugins": [ debug-bar" , "health-check" , "create-block-theme" , "gutenberg" ]

I guess the Test PR with Playground link isn't working for subsequent PRs? @adamziel

@@ -13,6 +13,9 @@
"features": {
"networking": true
},
"plugins": [
"create-block-theme"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zaerl, it looks like a comma is missing from the end of the array literal, and this makes the JSON invalid.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

@brandonpayton
Copy link
Member

I guess the Test PR with Playground link isn't working for subsequent PRs?

@bph there is currently a small syntax error in the JSON update. Otherwise, I think/hope the Playground preview remains working as expected.

@zaerl zaerl requested a review from brandonpayton December 23, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

Theme tester update
3 participants