Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to finn-base repo #1175

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Update links to finn-base repo #1175

merged 1 commit into from
Sep 10, 2024

Conversation

senekor
Copy link

@senekor senekor commented Sep 4, 2024

finn-base seems to be deprecated and the pointed-to files now have equivalents in the finn repo.

@auphelia
Copy link
Collaborator

auphelia commented Sep 9, 2024

Hi @senekor,
Thank you for your PR! Good catch with the outdated links.
Could you please sign-off your commit? To be compliant with our contribution guidelines: https://github.com/Xilinx/finn/blob/main/CONTRIBUTING.md
It should be possible to sign-off already pushed commits.

Signed-off-by: Remo Senekowitsch <senk@zhaw.ch>
@senekor
Copy link
Author

senekor commented Sep 9, 2024

@auphelia done 🙂

@auphelia
Copy link
Collaborator

Thank you @senekor !

@auphelia auphelia merged commit 972378a into Xilinx:dev Sep 10, 2024
2 checks passed
@senekor senekor deleted the update-links branch September 26, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants