Honor digits even for challenge #429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ykchalresp tool will output a six or eight digit OTP code even if challenge mode is chosen. This change does that for the ykman tool. In order to know if the user has selected six or eight digits, I added a zero selection to digits (although the text still says six). Later, if TOTP mode is selected and digits is zero, we change the zero to six. This way, behavior is the same when TOTP is selected, or no digit count is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ykchalresp tool will output a six or eight digit OTP code even if
challenge mode is chosen. This change does that for the ykman tool.
In order to know if the user has selected six or eight digits, I added
a zero selection to digits (although the text still says six). Later, if
TOTP mode is selected and digits is zero, we change the zero to six.
This way, behavior is the same when TOTP is selected, or no digit
count is specified.