Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Reset Image state when src is updated #395

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidvedvick
Copy link

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id): Image does not refresh if preload is true #394
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

The <Image /> tag will not update if preload is set to true. This change resets the <Image /> state when the src changes and preload is true. This change will also properly clean-up the hidden image tag when the component unmounts.

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2023

CLA assistant check
All committers have signed the CLA.

@davidvedvick davidvedvick changed the title Reset state when src is updated [Bugfix] Reset state when src is updated Apr 7, 2023
@davidvedvick davidvedvick changed the title [Bugfix] Reset state when src is updated [Bugfix] Reset Image state when src is updated Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants