fix: Channel ID and Name in display settings metadata (#37)

This PR inlcudes the latest version ov libczirw to fix #13 Fixes #13
ZEISS · Aug 26, 2024 · 04316fe · 04316fe
1 parent 264fcb4
commit 04316fe
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/_pylibCZIrw/src/api/CZIwriteAPI.cpp b/_pylibCZIrw/src/api/CZIwriteAPI.cpp
@@ -92,7 +92,7 @@ void CZIwriteAPI::WriteMetadata(
       ssName << "";
       nameIsValid = false;
     }
-    return make_tuple(ssId.str(), make_tuple(true, ssName.str()));
+    return make_tuple(ssId.str(), make_tuple(nameIsValid, ssName.str()));
   };
 
   auto mdBldr = this->spWriter_->GetPreparedMetadata(prepareInfo);

diff --git a/libs/libCZIrw b/libs/libCZIrw
diff --git a/pylibCZIrw/tests/integration/write/test_write.py b/pylibCZIrw/tests/integration/write/test_write.py
@@ -200,13 +200,17 @@ def test_write_metadata_application_version_matches_package_version() -> None:
             },
             [
                 {
+                    "@Id": "Channel:0",
+                    "@Name": "TestCh0",
                     "IsSelected": "true",
                     "Color": "#FF010203",
                     "ColorMode": "Color",
                     "Low": "0.2",
                     "High": "0.8",
                 },
                 {
+                    "@Id": "Channel:1",
+                    "@Name": "TestCh1",
                     "IsSelected": "true",
                     "Color": "#FFFFFEFD",
                     "ColorMode": "Color",
@@ -239,6 +243,10 @@ def __flatten(setting: Union[List[OrderedDict], OrderedDict]) -> Iterator[Ordere
     with tempfile.TemporaryDirectory() as td:
         # Act
         with create_czi(join(td, "test.czi")) as test_czi:
+            # Write data to the CZI since behavior on empty images in not well-defined
+            test_czi.write(data=np.zeros((100, 100), dtype=np.uint8), plane={"C": 0})
+            test_czi.write(data=np.zeros((100, 100), dtype=np.uint8), plane={"C": 1})
+            # Write metadata
             test_czi.write_metadata(
                 document_name="TestWriteMetadata",
                 scale_x=1.0,