Components: Fix typescript #2451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Components left for resolving typescript errors:
|
kaloudis
reviewed
Oct 2, 2024
components/OnchainFeeInput.tsx
Outdated
| @@ -1,6 +1,6 @@ | |||
| import React, { useEffect, useState } from 'react'; | |||
| import { Text, TouchableWithoutFeedback, View } from 'react-native'; | |||
| import { StackNavigationProp } from '@react-navigation/native'; | |||
| import { StackNavigationProp } from '@react-navigation/stack'; | |||
kaloudis
reviewed
Oct 2, 2024
stores/UnitsStore.ts
Outdated
| @@ -117,7 +118,9 @@ export default class UnitsStore { | |||
|
|
|||
| if (!fiatEntry?.rate) { | |||
| return { | |||
| error: 'Rate for selected currency not available' | |||
| error: 'Rate for selected currency not available', | |||
There was a problem hiding this comment.
should these be localized?
shubhamkmr04
force-pushed
the
shubham/typescript-fixes
branch
4 times, most recently
from
e9d0cf3
to
60f0850
Compare
shubhamkmr04
force-pushed
the
shubham/typescript-fixes
branch
from
60f0850
to
22a8f38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.