Improve range calculation and tick spacing/placement #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2024 00:15
Range is now chosen so that tick labels are guaranteed to be as close to the actual value they label as possible (the height of a terminal row being the limiting factor). Ticks are placed at multiples of 10^n * {1, 2, 5} so they are always round numbers. The target number of ticks and the desired buffer at the top and bottom of the range in percent can be easily adjusted (in code).
This makes the y-axis tick labels more consistent, as there is now always one space separating the tick label from the axis line.
aantn
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Range is now chosen so that tick labels are guaranteed to be as close to the actual value they label as possible (the height of a terminal row being the limiting factor). Ticks are placed at multiples of 10^n * {1, 2, 5} so they are always round numbers.
The target number of ticks and the desired buffer at the top and bottom of the range in percent can be easily adjusted (in code).
Possible future work: Setting target tick count based on current height of terminal.
Before:
After: