Minor fixes and CI cleanup #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aantn
reviewed
Feb 18, 2024
|
If it's possible to keep the older ones there too, let's do it for now.
…On Sun, Feb 18, 2024, 15:31 Simon Vetter ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/test.yml
<#20 (comment)>:
> with:
path: ~/.cargo/git
key: ${{ runner.os }}-cargo-index-${{ hashFiles('**/Cargo.lock') }}
- name: Run
- uses: ***@***.***
+ uses: ***@***.***
What about the other replaced/updated actions?
—
Reply to this email directly, view it on GitHub
<#20 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYUB23UYPXT3SGZHRKK33YUH7CJAVCNFSM6AAAAABDJ6WY66VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOBXGI2DANRYHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
And generalized the tick formatting code
|
Action changes are removed. |
aantn
approved these changes
Feb 18, 2024
|
@aantn Reminder that you said you wanted to create a new release ;-) |
|
Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo.tomlfile (Closes Commit tagged asv0.7.0actually has version 0.6.0 in Cargo.toml #10)cargo fmtandclippysuggestions (fmtis very opinionated...)CI runs clean and smooth now, except for a caching error which didn't seem worth going into for me since the whole CI runs pretty fast anyway.