Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph View from pjarnfelt was perfected by me #21

Closed
wants to merge 12 commits into from

Conversation

Sod3n
Copy link

@Sod3n Sod3n commented Jul 8, 2023

Now all manipulations with reanimator can be maked in graph view.

pjarnfelt and others added 12 commits December 8, 2022 15:12
Сделано:
1. Теперь, когда switchnode теряет фокус, он убирается из инспектора
2. При выборе объекта без reanimator grapview очищается
3. Теперь редактировать ноды в inspector нельзя
4. Убран assets из тулбара
5. Добавление switch node доступно только при клике правой кнопки по другому ноду
6. При добавление нового нода graphview перегенерируется
7. Убран inspector view. Вместо этого теперь ноды редактируются в стандартном инспекторе
8. При выборе объекта без реанимотора, выскакивает меню с кнопкой добавления реаниматора.
9. При создании ноды сохраняются в "стандартных" папках.
10. Добавлен функционал переименовывания нодов
11. При добавление reanimator через graph view создаётся switch node с именем "Root" и привязывается к реаниматору.
12. При изменение связей у нодов, граф перегенерируется
13. Теперь есть возможность создавать simple animation node в graphview
1. Styles fixed
2. Cleaned up the general structure of the code (not as much but as I can)
1. You can now edit the name of the nodes, regardless of their location
2. Now the nodes can be dragged from the file manager to the switches in the graph to attach them.
3. Grid removed
4. Added styles for SimpleAnimationNodeView
5. Edges and ports are now non-clickable
6. Deleting a node using the delete button now unbinds the node from the parent and redraws the graph.
7. Now to change the name of the node, you need to double click on the name
8. Added "Edit Name" button to the context menu
9. Now, when clicking on the empty space of the graph, the owner of the reanimator (GameObject) is selected
1. Fixed a bug with incorrect setting of nodes
2. Visual improvements
1. Now, when adding a reanimator to a gameobject, a folder called gameobject is created in the reanimator folder, and already in this folder (switches subfolder) root is created
1. Fixed a bug where nodes tried to resize themselves when the graphview was already cleared.
1. Fixed "Edit Name" button
2. Added guides to readme
@JoshMayberry
Copy link

I just noticed this pull request.
(lol, wish I would have seen this earlier).

In case anything can help you with your implementation, here is how I implemented GraphView: https://github.com/JoshMayberry/ReanimatorHelper/tree/1f1b511ed3eb64b8ae72f56fcff345d552e1737b
image

I'm sure your implementation is much better than the one I cobbled together- but if my code can be of any help to you at all- use what you need from it. :D

@Sod3n
Copy link
Author

Sod3n commented Feb 9, 2024

@JoshMayberry Oh, just see your comment. Thx for providing another implementation. My one has only switch and basic animation nodes as i remember, so if you fully realized all functionality thats cool. I'd recommend mentioning that in Issues tab Visual editor enchancment so other can find your work.

@Sod3n
Copy link
Author

Sod3n commented Feb 9, 2024

Not all functionality was implemented so cant use properly

@Sod3n Sod3n closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants