added: continuing from the last read position #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devansh42
reviewed
Aug 23, 2023
| maxLogSize: opts.MaxLogSize, | ||
| logSize: fi.Size(), | ||
| // If the list of files is empty, the directory is empty | ||
| return len(fileList) == 0, nil |
There was a problem hiding this comment.
As per documentation Incase of empty fileList, readdir would return non nil error also, therefore we should check for io.eof error as well.
There was a problem hiding this comment.
I have added the exception for EOF in the check above. Here, if the error is EOF, the fileList will be empty by default. So this logic should work. Let me know if you find otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.