selectAll() Select only visible countries #197
Conversation
|
Deploy preview for frosty-benz-8c81bf ready! Built without sensitive environment variables with commit 064a18a |
|
Checked the deployed preview and I'm not exactly sure I like this new change, because now pressing on Select All ends up deselecting everything else that was before. I think the action that makes more sense with the Select/Deselect All is that they act on the filtered results only, although I would like more feedback on this. As for when this gets accepted, it's all up to the maintainers, mostly Aatish. Remember that this isn't a full-time job for anyone that contributes and in the interest of not breaking stuff, things move slowly. There's a Contribution Guide you can read if you're interested. |
|
What MrSpiffyClean suggested would be something more like "Add all filtered (search) to selection". |
This is to satisfy issue, "selectAll should select all visible regions". Which I created.
I'm pretty new to Github, so I am not really sure about the protocol for getting changes accepted.