-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update usage instructions for Flatpak #184
base: main
Are you sure you want to change the base?
Conversation
82f9f19
to
0288679
Compare
Apologies for the extra force-pushes. It should be ready for review now. |
@guihkx small mistake in your instructions.
Also, i'm not sure i like telling people they just need to use podman to build. At least we should give people the option: either you need cargo + rust, or if you don't want to install that you can run a container using podman (why Ubuntu 23.10 though, at least use a LTS or a recent version). But then again you can also use nix and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed change.
That's necessary because building this library on a distro that has a different glibc version than the one provided by the Freedesktop Runtime (which Spotify for Flatpak runs on), may cause the library not to work (see #24 and #28). And that's the reason why Ubuntu 23.10 was chosen: It has glibc 2.38, which is the same version present in the 23.08 Freedesktop Runtime, which was used by Spotify when I created this pull request, but now they've updated to 24.08, so I'll need to find another distro with the same glibc version...
I'm done because it's the solution that I tested and it's guaranteed work. People are, of course, free to choose whatever build methods they like. Or they can avoid the build process completely and try their luck with the pre-built library, but again, I can't guarantee that will work... |
0288679
to
682fb91
Compare
Updates:
|
I'm so sorry, I deleted the branch by mistake while I was pushing changes to this other branch I'm working on. |
682fb91
to
577b942
Compare
I think telling people to build the project using podman/docker adds a big dependency, complexity and potential issues from first-time users trying to set it up in their environment. Since I don't use Flatpak myself, I can't verify, maintain or help people having problems with these instructions either. So to be perfectly honest, I'd rather remove the Flatpak instructions altogether in order to avoid even more related issues collecting dust, than introduce new potential sources for them. They're just frustrating for both me who can't help and the users who likely won't get any answer in a useful time frame.
This seems like something that should have been in a separate PR. Either way I'm not convinced that removing the |
And also add Flatpak-specific build instructions.
577b942
to
358319f
Compare
Even though I disagree, I've now removed the build instructions for Flatpak. Alas, as already stated in the README, if Flatpak users use the This would be solved by building the library with Podman/Docker using a container that has the same glibc version used by the Flatpak runtime used by the Spotify app.
I guarantee they work, but I also understand what you're saying. The build instructions for Flatpak would also have to be updated yearly (i.e., when they move to a newer runtime, which is released once a year).
Alright, I've added them back. |
This simplifies things regarding the Flatpak set up.
Rendered page: https://github.com/guihkx/spotify-adblock/blob/readme-flatpak/README.md
Closes #112