Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web interface for Salary Prediction #727

Closed
wants to merge 2 commits into from

Conversation

MRMORNINGSTAR2233
Copy link

@MRMORNINGSTAR2233 MRMORNINGSTAR2233 commented Aug 2, 2024

Pull Request for ML-Crate 💡

Issue Title: Web interface for Salary Prediction

  • Info about the related issue (Aim of the project) :
  • Name: Akshaykumar
  • Email ID for further communication: aksh9881@gmail.com
  • GitHub ID: github.com/mrmorningstar2233
  • Idenitfy yourself: contributor

Closes: #issue603

Describe the add-ons or changes you've made 📃

Give a clear description of what have you added or modifications made

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested
Describe how have you verified the changes made

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

github-actions bot commented Aug 2, 2024

Our team will soon review your PR. Thanks @MRMORNINGSTAR2233 :)

@abhisheks008
Copy link
Owner

@MRMORNINGSTAR2233 fill out the details in the above template.

@abhisheks008 abhisheks008 linked an issue Aug 3, 2024 that may be closed by this pull request
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you changed the existing files and add your models. Use the models which are already implemented in this repository. Find the best fitted model and use that in the web app. Create a sub folder in the existing project folder and push your code for the web app. Also do not .DS_Store files.

@abhisheks008 abhisheks008 added Requested Changes ⚙️ Some changes have been requested in this PR. SSOC labels Aug 3, 2024
@MRMORNINGSTAR2233
Copy link
Author

Actually there was no model in that it was only an analysis no prediction model was there
so i created the model and add it there

@abhisheks008
Copy link
Owner

Remove the whole existing project and then put your files in proper project structure inside the project folder named as "Salary Prediction of Data Analytics with Web App".

@MRMORNINGSTAR2233
Copy link
Author

i have changed is it proper now?

@abhisheks008
Copy link
Owner

i have changed is it proper now?

No. Take a look at this project folder and arrange the README files and other existing files as per the given project, https://github.com/abhisheks008/DL-Simplified/tree/main/Brain%20Tumor%20Detection

Remove the .DS_Store files you are pushing inside the ML-Crate repository.

@MRMORNINGSTAR2233
Copy link
Author

i did another pull request please look around it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants