Update dependencies, fix incompatibility with image 0.24 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lovasoa your PR contains the whole renaming to |
Update to rustdct 0.7
Format, CI, clippy
And use criterion for that too instead of the nightly-only benchmark feature.
process_dct2_with_scratch() operates inplace now and the second parameter is the scratch space, not the output. Also the size of the scratch space depends on the algorithm that is selected at runtime, and also only depends on the max(width, height) instead of width*height so less scratch space can be allocated now.
It's not clear to me if this wants wrapping_sub or saturating_sub or abs_diff behaviour, but this implements what happened before in release mode where overflow panics are disabled: wrapping_sub.
Fix port to rustdct 0.7
|
@lovasoa Is this still being maintained? |
|
no 😬 |
* Add median hashing * Add tests and benches for median hashing --------- Co-authored-by: alexdelorenzo <you@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52