-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve packaging #3459 #3761
Open
pombredanne
wants to merge
29
commits into
develop
Choose a base branch
from
3459-improve-packaging
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve packaging #3459 #3761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now using only a pyproject.toml Reference: #3459 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #3459 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
We now have tow new packages that will be pubslihed as wheels: * licensedcode-data that contains only the plain text files for licenses and license rules * licensedcode-index that contains only the pre-built index with compressed licenses and license rules baked-in Reference: #3459 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #3459 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Remove old mumbo jumbo renaming manifests Reference: #3459 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #3459 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Actually make this works for building with flot. Reference: #3459 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Since we use pip with --no-build-isolation we need to provide flot before we install anything. Reference: #3459 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
These are now provided by the separate licensecode-data and licensecode-index packages. Reference: #3459 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
We must install flot first before doing any other installations. Also cleanup dead code. Reference: #3459 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #3459 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #3459 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
The plain pyproject.toml is for development only Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
- Remove dependencies that are not direct. - Start to abstract some of the dependencies on the licensedcode module. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Move packagedcode.__init__.py code to handlers.py to allow distributing multiple smaller packages built with flot. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This is cleaner and makes tracking licenses much easier. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Guard import with "try/except ImportError" towards packaging models as a standalone wheel Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* packagedcode-models only contains the models.py * packagedcode-pypi only contains the pypi code and depends on models. This way we have small minimal wheel needed to support FetchCode and python-inspector. Reference: #3459 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Use new pyproject TOML fiels for scancode * Build packagedcode-models and packagedcode-pypi Reference: #3459 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Guard the usage also when doing plain expression hanlding that rely on the SPDX license key data from the LicenseIndex/License cache. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves packaging of ScanCode by adopting flot as a build tool
With this we have an overall simpler and more explicit build including
Tasks
Run tests locally to check for errors.