Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the bundling system of blazor server/wasm and mvc. #19968

Merged
merged 33 commits into from
Dec 19, 2024

Conversation

maliming
Copy link
Member

@maliming maliming commented Jun 3, 2024

Resolves #19963

After this PR, we don't need the abp bundle command to manually create the global.js and global.css files.


How it works?

https://github.com/abpframework/abp/blob/dev/docs/en/Community-Articles/2024-11-25-Global-Assets/POST.md


LeptonX needs this PR change, and the template project also needs the LeptonX PR change.

We need to release the nightly build packages of abp and leptonx.


abp nightly build package: 9.1.0-preview20241210
leptonx nightly build package: 4.1.0-preview20241210


ABP and LeptonX are ready to merge, waiting for Volo to change and test.

https://github.com/volosoft/lepton/pull/2291
https://github.com/volosoft/volo/pull/17925

@maliming maliming added this to the 8.3-preview milestone Jun 3, 2024
@maliming maliming force-pushed the blazor-binding-runtime branch from 090870f to 1f97485 Compare June 4, 2024 05:19
@maliming maliming changed the title Create blazor global js&css at runtime. Unify the binding system of blazor server/wasm and mvc. Jun 5, 2024
@maliming maliming requested a review from realLiangshiwei June 6, 2024 09:34
@enisn enisn changed the title Unify the binding system of blazor server/wasm and mvc. Unify the bundling system of blazor server/wasm and mvc. Jun 12, 2024
@skoc10 skoc10 changed the base branch from dev to prerel-8.3 July 16, 2024 07:27
@maliming maliming modified the milestones: 8.3-preview, 9.0-preview Jul 29, 2024
@maliming maliming modified the milestones: 9.0-preview, 9.1-preview Sep 24, 2024
@maliming maliming changed the base branch from rel-8.3 to dev October 8, 2024 08:20
@hikalkan hikalkan modified the milestones: 9.1-preview, 9.2-preview Oct 8, 2024
@maliming maliming marked this pull request as ready for review November 25, 2024 03:40
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 19.6%, saving 196.63 KB.

Filename Before After Improvement Visual comparison
docs/en/Community-Articles/2024-11-13-BuiltIn-OpenApi-Documentation/img2.png 183.02 KB 175.30 KB -4.2% View diff
docs/en/Community-Articles/2024-11-13-BuiltIn-OpenApi-Documentation/img3.png 294.28 KB 270.62 KB -8.0% View diff
docs/en/Community-Articles/2024-11-25-Global-Assets/image.png 525.13 KB 359.87 KB -31.5% View diff

2253 images did not require optimisation.

@maliming maliming requested a review from EngincanV November 25, 2024 05:20
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 26.95652% with 84 lines in your changes missing coverage. Please review.

Project coverage is 51.92%. Comparing base (941b793) to head (96c1982).
Report is 275 commits behind head on dev.

Files with missing lines Patch % Lines
...vc/UI/Bundling/AbpAspNetCoreMvcUiBundlingModule.cs 24.00% 56 Missing and 1 partial ⚠️
...p.Core/Volo/Abp/Bundling/Styles/CssRelativePath.cs 0.00% 14 Missing ⚠️
...tCore/Mvc/UI/Bundling/BundleParameterDictionary.cs 0.00% 6 Missing ⚠️
...Core/Mvc/UI/Bundling/BundleConfigurationContext.cs 0.00% 3 Missing ⚠️
.../Mvc/UI/Bundling/AbpBundlingGlobalAssetsOptions.cs 80.00% 2 Missing ⚠️
...lo/Abp/AspNetCore/Mvc/UI/Bundling/BundleManager.cs 0.00% 1 Missing ⚠️
....Core/Volo/Abp/Cli/Bundling/Styles/StyleBundler.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #19968      +/-   ##
==========================================
+ Coverage   51.88%   51.92%   +0.04%     
==========================================
  Files        3174     3177       +3     
  Lines      101802   101945     +143     
  Branches     7703     7724      +21     
==========================================
+ Hits        52815    52939     +124     
- Misses      47370    47376       +6     
- Partials     1617     1630      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@enisn enisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made my final checks and I think it's ready to go now. Should we merge it now?

@maliming
Copy link
Member Author

I just made my final checks and I think it's ready to go now. Should we merge it now?

@realLiangshiwei is testing the Volo side. We will merge once all tests pass.

@maliming maliming merged commit a9e6900 into dev Dec 19, 2024
4 checks passed
@maliming maliming deleted the blazor-binding-runtime branch December 19, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create blazor global js&css at runtime.
6 participants