Fix CI

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
absmach · Dec 15, 2024 · 5a556e6 · 5a556e6
1 parent b4f941f
commit 5a556e6
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 16 deletions.
diff --git a/proplet/api/requests.go b/proplet/api/requests.go
@@ -49,8 +49,7 @@ func (r RPCRequest) Validate() error {
 }
 
 func (r RPCRequest) ParseParams() (interface{}, error) {
-	switch r.Method {
-	case "start":
+	if r.Method == "start" {
 		if len(r.Params) < 1 {
 			return nil, fmt.Errorf("start method: missing required parameters: %w", pkgerrors.ErrInvalidParams)
 		}
@@ -69,8 +68,9 @@ func (r RPCRequest) ParseParams() (interface{}, error) {
 			AppName: appName,
 			Params:  params,
 		}, nil
+	}
 
-	case "stop":
+	if r.Method == "stop" {
 		if len(r.Params) < 1 {
 			return nil, fmt.Errorf("stop method: missing required parameters: %w", pkgerrors.ErrInvalidParams)
 		}
@@ -83,10 +83,9 @@ func (r RPCRequest) ParseParams() (interface{}, error) {
 		return StopRequest{
 			AppName: appName,
 		}, nil
-
-	default:
-		return nil, fmt.Errorf("unknown method '%s': %w", r.Method, pkgerrors.ErrInvalidMethod)
 	}
+
+	return nil, fmt.Errorf("unknown method '%s': %w", r.Method, pkgerrors.ErrInvalidMethod)
 }
 
 func parseStringSlice(params []interface{}) ([]string, error) {

diff --git a/proplet/service.go b/proplet/service.go
@@ -173,7 +173,7 @@ func (p *PropletService) handleStartCommand(ctx context.Context, _ string, msg m
 
 	startReq, ok := parsed.(api.StartRequest)
 	if !ok {
-		return fmt.Errorf("unexpected request type for start command")
+		return errors.New("unexpected request type for start command")
 	}
 
 	logger.Info("Received start command", slog.String("app_name", startReq.AppName))
@@ -232,16 +232,16 @@ func (p *PropletService) handleStartCommand(ctx context.Context, _ string, msg m
 		case <-timeout:
 			return fmt.Errorf("timed out waiting for chunks for app '%s'", startReq.AppName)
 		default:
-			p.chunksMutex.Lock()
-			metadata, exists := p.chunkMetadata[startReq.AppName]
-			receivedChunks := len(p.chunks[startReq.AppName])
-			p.chunksMutex.Unlock()
+		p.chunksMutex.Lock()
+		metadata, exists := p.chunkMetadata[startReq.AppName]
+		receivedChunks := len(p.chunks[startReq.AppName])
+		p.chunksMutex.Unlock()
 
-			if exists && receivedChunks == metadata.TotalChunks {
-				go p.deployAndRunApp(ctx, startReq.AppName)
+		if exists && receivedChunks == metadata.TotalChunks {
+			go p.deployAndRunApp(ctx, startReq.AppName)
 
-				return nil
-			}
+			return nil
+		}
 
 			time.Sleep(pollingInterval)
 		}
@@ -266,7 +266,7 @@ func (p *PropletService) handleStopCommand(ctx context.Context, _ string, msg ma
 
 	stopReq, ok := parsed.(api.StopRequest)
 	if !ok {
-		return fmt.Errorf("unexpected request type for stop command")
+		return errors.New("unexpected request type for stop command")
 	}
 
 	logger.Info("Received stop command", slog.String("app_name", stopReq.AppName))