vrrp: fix persistent FAULT state with use_vmac on a down base interface #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the base interface of VMAC is down at startup, the VRRP instance will remain on FAULT state even if the base interface is set up. keepalived uses a vrrp->num_script_if_fault fault counter that is incremented when there is a new fault and decremented when the fault is recovered. When the counter equals to zero, it considers there is no fault. try_up_instance() is used to decrease the counter. Since 4c7a94a ("vrrp: Make VMAC IPv6 link local address mirror parent interface"), it was not called anymore when a IPv6 link-local was back on the VMAC interface. Increment vrrp->num_script_if_fault when an IPv6 appears on the VMAC. Fixes: 4c7a94a ("vrrp: Make VMAC IPv6 link local address mirror parent interface") Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
louis-6wind
force-pushed
the
ll-fault-state
branch
from
28c4b43
to
84c2806
Compare
This was referenced Apr 4, 2023
VRRPv3 IPv6: persistent FAULT state when updating VMAC with a non-existent VMAC base interface
#2280
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the base interface of VMAC is down at startup, the VRRP instance will remain on FAULT state even if the base interface is set up.
Since the base interface is down, the VMAC operational state is also down and there is no operational IPv6 address. keepalived increments vrrp->num_script_if_fault. When the interface comes up, the link-local IPv6 address is set but vrrp->num_script_if_fault is not decremented. keepalived considers that there is still a remaining fault and keeps the VRRP instance in FAULT state.
Increment vrrp->num_script_if_fault when an IPv6 appears on the VMAC.
Fixes: 4c7a94a ("vrrp: Make VMAC IPv6 link local address mirror parent interface")