vrrp: use instance fault flags instead of a counter #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmetic change in try_up_instance() in order to prepare the next commits. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Cosmetic change in try_up_instance() in order to prepare the next commits. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Cosmetic change in down_instance() in order to prepare the next commits. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
The num_script_if_fault counter is not very convenient. We don't easily know what has incremented and decremented the counter. And the counter could go back to zero for a reason in case of a bug. Use an instance fault flags 'flags_if_fault' instead of a counter. Keep the a counter 'num_track_fault' for tracked object. Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The num_script_if_fault counter is not very convenient. We don't easily
know what has incremented and decremented the counter. And the counter
could go back to zero for a reason in case of a bug.
Use an instance fault flags 'flags_if_fault' instead of a counter. Keep
the a counter 'num_track_fault' for tracked object.
Signed-off-by: Louis Scalbert louis.scalbert@6wind.com