Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Citeproc functionality #3202

Merged
merged 13 commits into from
Apr 21, 2024
Merged

Add Citeproc functionality #3202

merged 13 commits into from
Apr 21, 2024

Conversation

mbollmann
Copy link
Member

This PR adds citeproc functionality into the new library.

@mbollmann mbollmann added the python-library Concerning the acl-anthology-py library label Apr 14, 2024
@mbollmann
Copy link
Member Author

@mjpost Codecov is not (fully?) working here, it only shows some of the recent commits and gives an error in the workflows here:

[2024-04-14T16:45:27.700Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

Can you check if it’s authorized properly?

@mjpost
Copy link
Member

mjpost commented Apr 17, 2024

Hi @mbollmann, can you remind me how to do that?

@mbollmann
Copy link
Member Author

@mjpost I made a request to authorize the Codecov app; can you see it? There also needs to be a token added to the repository secrets as described here.

@mbollmann mbollmann changed the title Add Citeproc functionality [WIP] Add Citeproc functionality Apr 20, 2024
@mbollmann mbollmann marked this pull request as ready for review April 20, 2024 12:35
@mbollmann mbollmann merged commit 9dd6d22 into python-dev Apr 21, 2024
11 checks passed
@mbollmann mbollmann deleted the python-add-citeproc branch April 21, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python-library Concerning the acl-anthology-py library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants