Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS-4373: Make Acquia CMS Toolbar and Tour work independent. #1909

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

rajeshreeputra
Copy link
Contributor

Motivation
Toolbar and Tour should work independently without the Acquia Drupal Starter Kit Common module.
Fixes #ACMS-4373

Proposed changes
Remove Acquia Drupal Starter Kit Common module dependency.

Alternatives considered
NA

Testing steps
Follow from ticket

Merge requirements

  • Major change, Minor change, Bug, Enhancement, and/or Chore label applied
  • Manual testing by a reviewer

@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 23, 2024 05:08 — with GitHub Actions Inactive
case 'content_administrator':
$role->grantPermission('access acquia cms tour dashboard');
user_role_grant_permissions('content_administrator', ['access acquia cms tour dashboard']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why passing hard-coded role name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are assigning permissions exclusively to the role with the matching ID content_administrator.

@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment December 23, 2024 08:55 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants