Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET 9 Update to fix armv7l breakage #3573

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

.NET 9 Update to fix armv7l breakage #3573

wants to merge 4 commits into from

Conversation

satmandu
Copy link
Contributor

@satmandu satmandu commented Nov 14, 2024 •
edited
Loading

Fixes #3505

  • .NET 9.0 was released on November 12, 2024, which fixes the underlying issue with the armv7l breakage on newer ubuntu containers due to arm32 Y2038 compatibility issues with the underlying Ubuntu/Debian operating systems moving to 64-bit time.
  • These fixes are in .NET 9.0, but will not be backported to .NET 8.0 as per Breaking change: .NET 9 is Y2038 compatible (Arm32 glibc); .NET 8 is not dotnet/core#9285
  • I also updated the builds to use ubuntu/noble (LTS) since .NET 9.0 doesn't appear to be supported on the older ubuntu jammy containers.

@satmandu
Bump version locally to test new arm builds.
5f43813 
Signed-off-by: Satadru Pramanik <satadru@gmail.com>
@satmandu
Update to .Net 9.0 to fix ARM32 Y2038 breakage.
5b10438 
This updates .Net to 9.0.100-rc.2.24474.11 .
See actions#3505
dotnet/runtime#101444
dotnet/runtime#96460
dotnet/runtime#102410

(Looks like this has not been backported to .Net 8.x...)

Signed-off-by: Satadru Pramanik <satadru@gmail.com>
@satmandu
Update to .Net 9.0 Final.
7a2fc6f 
Signed-off-by: Satadru Pramanik <satadru@gmail.com>
@satmandu
Revert local changes for local build for PR submission upstream.
a6e4ede 
Signed-off-by: Satadru Pramanik <satadru@gmail.com>
@satmandu satmandu requested a review from a team as a code owner November 14, 2024 16:43
@satmandu satmandu mentioned this pull request Nov 14, 2024
Open
@satmandu satmandu changed the title Dot net 9 Update to fix armv7l breakage .Net 9 Update to fix armv7l breakage Nov 14, 2024
malik-n
malik-n approved these changes Nov 14, 2024
View reviewed changes
Copy link

@malik-n malik-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Updating .NET to version 9 is necessary to keep supporting armv7 as .NET won't fix the incompatibilty in version 8.

@satmandu satmandu changed the title .Net 9 Update to fix armv7l breakage .NET 9 Update to fix armv7l breakage Nov 14, 2024
@TingluoHuang
Copy link
Member

I assume we will lose the support for ubuntu 20.04 or debian 11 for arm32?

@malik-n
Copy link

malik-n commented Nov 14, 2024

I assume we will lose the support for ubuntu 20.04 or debian 11 for arm32?

users of these versions might have to install .NET 9.0 from the Microsoft repository.
But they migt need a higher glibc version also.

I will check if thats reasonable

@TingluoHuang
Copy link
Member

https://github.com/dotnet/core/blob/main/release-notes/8.0/supported-os.md#linux-compatibility

Basically, the dotnet 8 runner should work on ubuntu 22.04 or below, just not ubuntu 24.04 or above is what my understand.

@satmandu
Copy link
Contributor Author

https://github.com/dotnet/core/blob/main/release-notes/8.0/supported-os.md#linux-compatibility

Basically, the dotnet 8 runner should work on ubuntu 22.04 or below, just not ubuntu 24.04 or above is what my understand.

That is also my understanding. The newer breakage is only with 32-bit runners. (We don't have this issue with our x86 32-bit runner because we run that inside a x86_64 based container...)

@malik-n
Copy link

malik-n commented Nov 15, 2024

https://github.com/dotnet/core/blob/main/release-notes/8.0/supported-os.md#linux-compatibility

Basically, the dotnet 8 runner should work on ubuntu 22.04 or below, just not ubuntu 24.04 or above is what my understand.

I eventually also came to that understanding. We are propably able to stay on jammy so I am trying this out right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malik-n malik-n malik-n approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@satmandu @TingluoHuang @malik-n