CheckoutV2: Add metadata to Credit #5328
Open
+37
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almalee24
force-pushed
the
update_checkout_credit
branch
from
300e6e0 to
085cc9c
Compare
almalee24
force-pushed
the
update_checkout_credit
branch
from
085cc9c to
b658ecd
Compare
almalee24
force-pushed
the
update_checkout_credit
branch
from
b658ecd to
09ba029
Compare
Add metadata to Credit and pending as a field for response. Set pending to true for CheckoutV2 if a Credit returns status of Pending. Only add response['error_codes'] to the message if it exist. Remote 113 tests, 282 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 67 tests, 420 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metadata to Credit and pending as a field for response. Set pending to true for CheckoutV2 if a Credit returns status of Pending.
Remote 113 tests, 282 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Unit:
67 tests, 420 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed