-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: modernise map utils #3615
base: main
Are you sure you want to change the base?
Conversation
@@ -27,6 +27,28 @@ | |||
using Acts::VectorHelpers::perp; | |||
using Acts::VectorHelpers::phi; | |||
|
|||
namespace { | |||
auto getMinMaxAndBinCount(std::vector<double>& xPos) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be deduplicated with the function below also named getMinMaxAndBinCount
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding it to Helpers.hpp
?
https://github.com/acts-project/acts/blob/main/Core/include/Acts/Utilities/Helpers.hpp
Quality Gate passedIssues Measures |
No description provided.