-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rename CKFPerformanceWriter
in Examples
#3763
Merged
kodiakhq
merged 3 commits into
acts-project:main
from
andiwand:ex-rename-ckf-perf-writer
Oct 19, 2024
Merged
refactor: Rename CKFPerformanceWriter
in Examples
#3763
kodiakhq
merged 3 commits into
acts-project:main
from
andiwand:ex-rename-ckf-perf-writer
Oct 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Examples
Affects the Examples module
Infrastructure
Changes to build tools, continous integration, ...
Changes Performance
labels
Oct 19, 2024
andiwand
force-pushed
the
ex-rename-ckf-perf-writer
branch
from
October 19, 2024 11:13
29c819f
to
fe77ae7
Compare
andiwand
added
🛑 blocked
This item is blocked by another item
and removed
🛑 blocked
This item is blocked by another item
labels
Oct 19, 2024
andiwand
force-pushed
the
ex-rename-ckf-perf-writer
branch
from
October 19, 2024 15:27
fe77ae7
to
d423ab4
Compare
AJPfleger
approved these changes
Oct 19, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes Performance
Component - Examples
Affects the Examples module
Infrastructure
Changes to build tools, continous integration, ...
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #3737
I usually expect some accumulated plots in the performance writers we can directly look at. At the same time the
CKFPerformanceWriter
is generic enough to write the performance for any finder.Therefore I propose to
TrackFinderPerformanceWriter
toTrackFinderNTupleWriter
(refactor: RenameTrackFinderPerformanceWriter
in Examples #3737)CKFPerformanceWriter
toTrackFinderPerformanceWriter
(this pr)blocked by
TrackFinderPerformanceWriter
in Examples #3737