Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Navigation assertions in validation tools #858

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Navigation assertions in validation tools #858

wants to merge 2 commits into from

Conversation

niermann999
Copy link
Contributor

Fixes two assertions that were triggered by navigation validation tools:

  • if the step stracer is set to record every step, make sure the barcode is only accessed when actually on surface
  • since rays return zero for 'qop', make sure the free track parameter momentum is only written to file if it can be retrieved. Otherwise write the (normalized) direction to file

@niermann999 niermann999 added bug Something isn't working priority: medium medium priority labels Oct 16, 2024
@niermann999
Copy link
Contributor Author

Based on #856

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@niermann999 niermann999 added the blocked This item is blocked by another item label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked This item is blocked by another item bug Something isn't working priority: medium medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@niermann999