Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs related to adafruit_wm8960.WM8960.input and adafruit_wm8960.WM8960.gain properties. #5

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Fix bugs related to adafruit_wm8960.WM8960.input and adafruit_wm8960.WM8960.gain properties. #5

merged 3 commits into from
Nov 5, 2024

Conversation

relic-se
Copy link
Contributor

@relic-se relic-se commented Nov 5, 2024

The following issues have been tested and resolved:

  • Invalid value of mic_mute when mic input is selected.
  • Update input gain correctly within setter of adafruit_wm8960.WM8960.input.
  • Properly mute line inputs when not selected.

FoamyGuy
FoamyGuy approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

Don't have the hardware to test.

@FoamyGuy FoamyGuy merged commit f580f5f into adafruit:main Nov 5, 2024
1 check passed
@relic-se
Copy link
Contributor Author

relic-se commented Nov 5, 2024

Thanks for the merge! I can provide video demonstrations if needed, but the fixes were pretty clear cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@relic-se @FoamyGuy