Add a "posix port" #9581
Draft
Add a "posix port" #9581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
later, posix will hook into here somehow
the tests fail due to printing numbers differently
the bitmap* tests now pass
this fixes some test failures that rely on exact python float values
this is defined by python (returns 0) and tested in a test
.. will need to do the same in other asyncio tests
now you can use the same name shown in a list of failures/skips, e.g., `make test-random_basic || make print-failures`
later I'll want to switch it to float & endorse the new results but for now just do this.
This change allows the unix/time_mktime_localtime.py test to work in the POSIX build
.. shouldn't it say CircuitPython though?
we don't use this capability in CircuitPython but it was not hard to make it work. Removing the "extensible module" related code altogether might save some space though.
this doesn't run in host python because python is invoked with the -S flag, disabling site packages (msgpack is not part of base python, it's installed via pip if it's available) I verified the message decodes in standard python with msgpack.
.. it now fails on unix coverage port but that's fine
this fixes some synthio tests that differed in output, because dynamic range compression depends on the channel count.
qrio has an existing test, gifio does not
|
I reached a milestone of 0 failed tests so I felt it would be worth PR'ing. The list of conflicts is pretty extensive so I'll probably need to rebase this. This work is not an Adafruit priority so I'll also reserve the possibility of just closing this up so it doesn't linger in draft status. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "posix port" aims to enable compile-time tests that we currently do with the "unix port", but with a build that uses as much of the CircuitPython shared-bindings & supervisor as possible. Once we have to stop maintaining changes within micropython's unix port, this removes one of the hassles of merging micropython changes into circuitpython. It may also enable testing new parts of the shared-modules libraries (for instance, gifio has become testable though this change)
Locally this test suite runs to completion, though it has more skips than the unix port did/does.
vs
notably, the "vfs" tests are skipped.
This has been in the works for awhile and needs to be updated against the current main branch. Additionally at least some of the skipped tests would be good to cover (testing FAT filesystem on the host would be nice)