Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix os.uname() values for rp2350 #9683

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Oct 4, 2024

https://forums.adafruit.com/viewtopic.php?t=213955 by blakebr notes that os.uname().sysname and .nodename say rp2040 even for rp2350 boards. Fix this by using MICROPY_HW_MCU_NAME instead. Note that it would be rp2350a and rp2350b.

Note that on some ports, the name is more generic, such as samd21 and samd51 for atmel-samd. But espressif and broadcom use MICROPY_HW_MCU_NAME. In the long run, maybe that is better, since it's more informative, instead of using a generic name. This could be a 10.0 change.

@dhalbert dhalbert requested a review from tannewt October 4, 2024 02:26
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. Thanks!

@tannewt tannewt merged commit a693bd7 into adafruit:main Oct 4, 2024
136 checks passed
@dhalbert dhalbert deleted the raspberrypi-os-uname branch October 4, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants