-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid compiler warnings #287
Conversation
3f1f5f6
to
0c4a42e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good to me. @Rombur, any concerns?
Yes, don't merge it. I will do a proper review later but we should not merge as is. |
ci/Dockerfile
Outdated
@@ -220,6 +220,7 @@ RUN export TRILINOS_HASH=975307431d60d0859ebaa27c9169cbb1d4287513 && \ | |||
-DTrilinos_ENABLE_SEACAS=ON \ | |||
-DTrilinos_ENABLE_EXPLICIT_INSTANTIATION=ON \ | |||
-DKokkos_ENABLE_CUDA=$CUDA \ | |||
-DKokkos_ENABLE_CUDA_CONSTEXPR=$CUDA \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't modify the Dockerfile. This will unsync the image with the Dockerfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I'll remove but most of the warnings are related to setting this option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then why are you setting this option if it creates a bunch of warnings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It removes all warnings related to calling constexpr
host
functions. This is also what we are doing in the deal.II
CI, see https://github.com/dealii/dealii/blob/3c3910b004cec9be552eb224ceba4bc6fecd47b6/.github/workflows/linux.yml#L335, and we check for this option to be set for an external standalone Kokkos
, see https://github.com/dealii/dealii/blob/3c3910b004cec9be552eb224ceba4bc6fecd47b6/cmake/modules/FindDEAL_II_KOKKOS.cmake#L53.
0c4a42e
to
166710a
Compare
While working on #282, I noticed that there are more warnings which this pull request fixes. I wasn't sure if we wanted to enforce this with
-Werror
or similar.