Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports unclutter #884

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Conversation

YoshiRulz
Copy link
Contributor

Moves some types from the SharpCompress namespace to SharpCompress.Helpers, so they won't be used accidentally by consumers. (Builds upon #579.) And removes the redundant ReadOnlyCollection<T>.

@adamhathcock
Copy link
Owner

Looks great, thanks!

I changed the param type of the helper, but the stronger constraint
didn't seem to matter in practice
auto-merge was automatically disabled December 19, 2024 12:11

Head branch was pushed to by a user without write access

@YoshiRulz
Copy link
Contributor Author

I think I figured out your autoformatter? Just removed 2 blank lines.

@adamhathcock adamhathcock merged commit 7f79c49 into adamhathcock:master Dec 19, 2024
2 checks passed
@YoshiRulz YoshiRulz deleted the exports-unclutter branch December 19, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants