fix potential crash where empty data array can be passed to the library

adamstark · May 18, 2023 · f46a4e4 · f46a4e4
1 parent 2a96219
commit f46a4e4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/AudioFile.h b/AudioFile.h
@@ -1245,6 +1245,9 @@ void AudioFile<T>::clearAudioBuffer()
 template <class T>
 AudioFileFormat AudioFile<T>::determineAudioFileFormat (const std::vector<uint8_t>& fileData)
 {
+    if (fileData.size() < 4)
+        return AudioFileFormat::Error;
+
     std::string header (fileData.begin(), fileData.begin() + 4);
 
     if (header == "RIFF")

diff --git a/tests/GeneralTests.cpp b/tests/GeneralTests.cpp
@@ -107,4 +107,13 @@ TEST_SUITE ("General Tests")
 
         checkFilesAreExactlyTheSame<int16_t> (a, b);
     }
+
+    //=============================================================
+    TEST_CASE ("GeneralTests::Empty Data")
+    {        
+        AudioFile<float> a;
+        a.shouldLogErrorsToConsole (false);
+        bool result = a.loadFromMemory (std::vector<uint8_t>());
+        CHECK_EQ (result, false);
+    }
 }