Skip to content

Commit

Permalink
Ignore too-many-positional-arguments errors
Browse files Browse the repository at this point in the history
  • Loading branch information
charlesbvll committed Oct 11, 2024
1 parent a5ff98e commit 90f64f9
Show file tree
Hide file tree
Showing 21 changed files with 27 additions and 26 deletions.
2 changes: 1 addition & 1 deletion src/py/flwr/client/grpc_adapter_client/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@


@contextmanager
def grpc_adapter( # pylint: disable=R0913
def grpc_adapter( # pylint: disable=R0913,too-many-positional-arguments
server_address: str,
insecure: bool,
retry_invoker: RetryInvoker,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/client/grpc_client/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def on_channel_state_change(channel_connectivity: str) -> None:


@contextmanager
def grpc_connection( # pylint: disable=R0913, R0915
def grpc_connection( # pylint: disable=R0913,R0915,too-many-positional-arguments
server_address: str,
insecure: bool,
retry_invoker: RetryInvoker, # pylint: disable=unused-argument
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/client/grpc_rere_client/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def on_channel_state_change(channel_connectivity: str) -> None:


@contextmanager
def grpc_request_response( # pylint: disable=R0913, R0914, R0915
def grpc_request_response( # pylint: disable=R0913,R0914,R0915,too-many-positional-arguments
server_address: str,
insecure: bool,
retry_invoker: RetryInvoker,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/client/node_state.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def __init__(
self.node_config = node_config
self.run_infos: dict[int, RunInfo] = {}

# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments
def register_context(
self,
run_id: int,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/client/rest_client/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@


@contextmanager
def http_request_response( # pylint: disable=,R0913, R0914, R0915
def http_request_response( # pylint: disable=R0913,R0914,R0915,too-many-positional-arguments
server_address: str,
insecure: bool, # pylint: disable=unused-argument
retry_invoker: RetryInvoker,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/common/logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def update_console_handler(
class CustomHTTPHandler(HTTPHandler):
"""Custom HTTPHandler which overrides the mapLogRecords method."""

# pylint: disable=too-many-arguments,bad-option-value,R1725
# pylint: disable=too-many-arguments,bad-option-value,R1725,R0917
def __init__(
self,
identifier: str,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/common/message.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class Metadata: # pylint: disable=too-many-instance-attributes
the receiving end.
"""

def __init__( # pylint: disable=too-many-arguments
def __init__( # pylint: disable=too-many-arguments,too-many-positional-arguments
self,
run_id: int,
message_id: str,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/server/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ def _run_fleet_api_grpc_adapter(
return fleet_grpc_server


# pylint: disable=import-outside-toplevel,too-many-arguments
# pylint: disable=import-outside-toplevel,too-many-arguments,too-many-positional-arguments
def _run_fleet_api_rest(
host: str,
port: int,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/server/compat/driver_client_proxy_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def test_evaluate_and_fail(self) -> None:
)
self._common_assertions(ins)

def _create_message_dummy( # pylint: disable=R0913
def _create_message_dummy( # pylint: disable=R0913,too-many-positional-arguments
self,
content: RecordSet,
message_type: str,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/server/driver/driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def run(self) -> Run:
"""Run information."""

@abstractmethod
def create_message( # pylint: disable=too-many-arguments
def create_message( # pylint: disable=too-many-arguments,too-many-positional-arguments
self,
content: RecordSet,
message_type: str,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/server/driver/grpc_driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ def _check_message(self, message: Message) -> None:
):
raise ValueError(f"Invalid message: {message}")

def create_message( # pylint: disable=too-many-arguments
def create_message( # pylint: disable=too-many-arguments,too-many-positional-arguments
self,
content: RecordSet,
message_type: str,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/server/driver/inmemory_driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def run(self) -> Run:
self._init_run()
return Run(**vars(cast(Run, self._run)))

def create_message( # pylint: disable=too-many-arguments
def create_message( # pylint: disable=too-many-arguments,too-many-positional-arguments
self,
content: RecordSet,
message_type: str,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/server/server_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class ServerApp:
>>> print("ServerApp running")
"""

# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments
def __init__(
self,
server: Optional[Server] = None,
Expand Down
4 changes: 2 additions & 2 deletions src/py/flwr/server/strategy/dp_adaptive_clipping.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class DifferentialPrivacyServerSideAdaptiveClipping(Strategy):
>>> )
"""

# pylint: disable=too-many-arguments,too-many-instance-attributes
# pylint: disable=too-many-arguments,too-many-instance-attributes,too-many-positional-arguments
def __init__(
self,
strategy: Strategy,
Expand Down Expand Up @@ -307,7 +307,7 @@ class DifferentialPrivacyClientSideAdaptiveClipping(Strategy):
>>> )
"""

# pylint: disable=too-many-arguments,too-many-instance-attributes
# pylint: disable=too-many-arguments,too-many-instance-attributes,too-many-positional-arguments
def __init__(
self,
strategy: Strategy,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/server/strategy/dpfedavg_adaptive.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class DPFedAvgAdaptive(DPFedAvgFixed):
This class is deprecated and will be removed in a future release.
"""

# pylint: disable=too-many-arguments,too-many-instance-attributes
# pylint: disable=too-many-arguments,too-many-instance-attributes,too-many-positional-arguments
def __init__(
self,
strategy: Strategy,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/server/strategy/dpfedavg_fixed.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class DPFedAvgFixed(Strategy):
This class is deprecated and will be removed in a future release.
"""

# pylint: disable=too-many-arguments,too-many-instance-attributes
# pylint: disable=too-many-arguments,too-many-instance-attributes,too-many-positional-arguments
def __init__(
self,
strategy: Strategy,
Expand Down
4 changes: 2 additions & 2 deletions src/py/flwr/server/superlink/fleet/grpc_bidi/grpc_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def valid_certificates(certificates: tuple[bytes, bytes, bytes]) -> bool:
return is_valid


def start_grpc_server( # pylint: disable=too-many-arguments
def start_grpc_server( # pylint: disable=too-many-arguments,too-many-positional-arguments
client_manager: ClientManager,
server_address: str,
max_concurrent_workers: int = 1000,
Expand Down Expand Up @@ -156,7 +156,7 @@ def start_grpc_server( # pylint: disable=too-many-arguments
return server


def generic_create_grpc_server( # pylint: disable=too-many-arguments
def generic_create_grpc_server( # pylint: disable=too-many-arguments,too-many-positional-arguments
servicer_and_add_fn: Union[
tuple[FleetServicer, AddServicerToServerFn],
tuple[GrpcAdapterServicer, AddServicerToServerFn],
Expand Down
3 changes: 2 additions & 1 deletion src/py/flwr/server/superlink/fleet/vce/vce_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ def put_taskres_into_state(
pass


# pylint: disable=too-many-positional-arguments
def run_api(
app_fn: Callable[[], ClientApp],
backend_fn: Callable[[], Backend],
Expand Down Expand Up @@ -251,7 +252,7 @@ def run_api(


# pylint: disable=too-many-arguments,unused-argument,too-many-locals,too-many-branches
# pylint: disable=too-many-statements
# pylint: disable=too-many-statements,too-many-positional-arguments
def start_vce(
backend_name: str,
backend_config_json_stream: str,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/server/superlink/fleet/vce/vce_api_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ def _autoresolve_app_dir(rel_client_app_dir: str = "backend") -> str:
return str(rel_app_dir.parent / rel_client_app_dir)


# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments
def start_and_shutdown(
backend: str = "ray",
client_app_attr: Optional[str] = None,
Expand Down
2 changes: 1 addition & 1 deletion src/py/flwr/simulation/ray_transport/ray_client_proxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
class RayActorClientProxy(ClientProxy):
"""Flower client proxy which delegates work using Ray."""

def __init__( # pylint: disable=too-many-arguments
def __init__( # pylint: disable=too-many-arguments,too-many-positional-arguments
self,
client_fn: ClientFnExt,
node_id: int,
Expand Down
8 changes: 4 additions & 4 deletions src/py/flwr/simulation/run_simulation.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ def run_simulation_from_cli() -> None:


# Entry point from Python session (script or notebook)
# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments
def run_simulation(
server_app: ServerApp,
client_app: ClientApp,
Expand Down Expand Up @@ -300,7 +300,7 @@ def run_simulation(
)


# pylint: disable=too-many-arguments
# pylint: disable=too-many-arguments,too-many-positional-arguments
def run_serverapp_th(
server_app_attr: Optional[str],
server_app: Optional[ServerApp],
Expand Down Expand Up @@ -369,7 +369,7 @@ def server_th_with_start_checks(
return serverapp_th


# pylint: disable=too-many-locals
# pylint: disable=too-many-locals,too-many-positional-arguments
def _main_loop(
num_supernodes: int,
backend_name: str,
Expand Down Expand Up @@ -455,7 +455,7 @@ def _main_loop(
log(DEBUG, "Stopping Simulation Engine now.")


# pylint: disable=too-many-arguments,too-many-locals
# pylint: disable=too-many-arguments,too-many-locals,too-many-positional-arguments
def _run_simulation(
num_supernodes: int,
exit_event: EventType,
Expand Down

0 comments on commit 90f64f9

Please sign in to comment.