feat(datasets) Add DivideResplitter #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-narozniak
requested review from
danieljanes and
tanertopal
as code owners
jafermarq
reviewed
Mar 27, 2024
| start_index = 0 | ||
| end_index = 0 | ||
| split_data = dataset[split_from] | ||
| assert isinstance(new_splits_dict, dict) |
There was a problem hiding this comment.
This assert will never be triggered, right?
There was a problem hiding this comment.
Yes, at this point it's adjusted correctly (based on the python logic) but the type checkers complained
There was a problem hiding this comment.
ok, let's keep if they complain. w/ Py3.10 it seemed to be fine
adam-narozniak
commented
Apr 24, 2024
| start_index = 0 | ||
| end_index = 0 | ||
| split_data = dataset[split_from] | ||
| assert isinstance(new_splits_dict, dict) |
There was a problem hiding this comment.
Yes, at this point it's adjusted correctly (based on the python logic) but the type checkers complained
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
adam-narozniak
changed the title
jafermarq
reviewed
May 17, 2024
| start_index = 0 | ||
| end_index = 0 | ||
| split_data = dataset[split_from] | ||
| assert isinstance(new_splits_dict, dict) |
There was a problem hiding this comment.
ok, let's keep if they complain. w/ Py3.10 it seemed to be fine
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
jafermarq
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Certain splits of the dataset need to be divided into smaller splits. No functionality exists to accomplish that that can be used in the FederatedDataset abstraction.
Proposal
Create a
DivideResplitterabstraction that solves the problem. See docstrings for more explanation.