-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flower Client App connection error handling #2969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbvll
changed the title
Add client connection retry handling
Add Flower Client App connection retry handling
Feb 18, 2024
charlesbvll
changed the title
Add Flower Client App connection retry handling
Add Flower Client App connection error handling
Feb 18, 2024
panh99
reviewed
Feb 29, 2024
Moep90
reviewed
Mar 4, 2024
danieljanes
reviewed
Mar 5, 2024
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
danieljanes
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
When starting a long-running Flower client app, if anything interrupts the connection between the server and the client, the client will crash (making it not so long running...).
Related issues/PRs
N/A
Proposal
Explanation
Use the existing
RetryInvoker
class to wrap the communication function calls in order to catch any communication error and retry to call the given function after some time.Checklist
#contributions
)Changelog entry
The
flower-client-app
will now try to reconnect indefinitely to theflower-superlink
in case of connection error. The arguments--max-retries
and--max-wait-time
can now be passed to theflower-client-app
,--max-retries
will define the number of tentatives the client should make before it gives up trying to reconnect to the Superlink, and,--max-wait-time
defines the time before the client gives up trying to reconnect to the Superlink.Any other comments?
N/A