Add partitioners property to FederatedDataset #3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafermarq
reviewed
Mar 13, 2024
jafermarq
reviewed
Mar 13, 2024
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
jafermarq
previously approved these changes
Mar 13, 2024
danieljanes
reviewed
Mar 13, 2024
danieljanes
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In order to plot the labels of different partitions, expose the partitioner object.
Description
Passing a single partitioner or multiple partitioners will be required by the plotting function.
Proposal
Trigger dataset download, and assignment, and then check if the specification of the partitioners matches the dataset splits. Then return the partitioners dictionary.
Changelog entry