fix(datasets) Fix the scale of value axis when plotting in absolute sizes #4255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-narozniak
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
jafermarq
reviewed
Oct 1, 2024
| return {"sharex": False, "sharey": False} | ||
|
|
||
|
|
||
| def _set_tick_on_value_axes( |
There was a problem hiding this comment.
would it make more sense to use the word disable_tick rather than set_tick?
There was a problem hiding this comment.
I can't google it. Could you send a link to matplotlib docs of disable_tick?
There was a problem hiding this comment.
oh, i mean the name of this function _set_tick_on_value_axes, but maybe i'm overthinking it
jafermarq
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When using
plot_comparison_label_distributioncomparing the distributions with absolute value, the value axis is plotted independently, proving incorrect value interpretation (due to the inconsistent scale).Proposal
Share the scale of the value axis in case of absolute values:
