Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommended helm labels #71

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

radu-catalina
Copy link
Contributor

Description

Add the recommended helm labels to all resources

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@radu-catalina radu-catalina requested a review from a team as a code owner August 25, 2023 14:50
Copy link
Member

@aalexandru aalexandru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aalexandru aalexandru merged commit 8b92be0 into adobe:main Aug 29, 2023
2 checks passed
@aalexandru aalexandru mentioned this pull request Aug 29, 2023
aalexandru pushed a commit to aalexandru/cluster-registry that referenced this pull request Sep 4, 2023
* Add recommended helm labels

* Increase chart version
aalexandru pushed a commit to aalexandru/cluster-registry that referenced this pull request Sep 18, 2023
* Add recommended helm labels

* Increase chart version
aalexandru pushed a commit to aalexandru/cluster-registry that referenced this pull request Sep 18, 2023
* Add recommended helm labels

* Increase chart version
aalexandru added a commit that referenced this pull request Oct 3, 2023
* Add service metadata endpoints

* New release 1.5.0-unstable (#70)

Co-authored-by: aalexandru <aalexand@adobe.com>

* Add chargebackBusinessUnit field; Remove k8sInfraRelease field (#74)

* Add chargebackBusinessUnit field; Remove k8sInfraRelease field

* Fix go deps

* go mod tidy

* Updated controller-gen version

* Fix go.sum imports

* Bump go version to 1.21

* Refactor deprecated clientConfig

* Refactor clientConfig webhook configuration

* Fix G304 (CWE-22)

* Add missing license

* Update makefile K8S_VERSION to 1.25.0

* Update controller-gen crd options

---------

Co-authored-by: aalexandru <aalexand@adobe.com>

* Add recommended helm labels (#71)

* Add recommended helm labels

* Increase chart version

* New release 1.4.2 (#75)

Co-authored-by: aalexandru <aalexand@adobe.com>

* Fix leader election (#76)

Co-authored-by: aalexandru <aalexand@adobe.com>

* Update kind version

* Add new crd & controller reconciliation logic

* Updated serviceMetadata patching logic

* make swagger

* Add chargebackBusinessUnit field; Remove k8sInfraRelease field (#74)

* Add chargebackBusinessUnit field; Remove k8sInfraRelease field

* Fix go deps

* go mod tidy

* Updated controller-gen version

* Fix go.sum imports

* Bump go version to 1.21

* Refactor deprecated clientConfig

* Refactor clientConfig webhook configuration

* Fix G304 (CWE-22)

* Add missing license

* Update makefile K8S_VERSION to 1.25.0

* Update controller-gen crd options

---------

Co-authored-by: aalexandru <aalexand@adobe.com>

* Update kind version

* Add new crd & controller reconciliation logic

* Updated serviceMetadata patching logic

* make swagger

* Add client config defaults

* Updated service metadata patching logic

* Ignore service object delete events

* Fix linting errors

* Add missing license

---------

Co-authored-by: aalexandru <aalexand@adobe.com>
Co-authored-by: caradu <caradu@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants