Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Argo Rollout controller object as a first class citizen #241

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

adriananeci
Copy link
Contributor

Description

Initially, we naively thought that if a pod is managed by a replicaset, then that replicaset is managed by a deployment object.
This is no longer the case, since objects like Argo Rollouts are also leveraging the replicaset objects to handle pods.

This PR adds support for Argo Rollout controller object as a first class citizen in shredder, and adjust their spec.restartAt filed setting when a rollout restart is identified as needed by k8s-shredder. See https://argo-rollouts.readthedocs.io/en/stable/features/restart/#restarting-rollout-pods for more details.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@adriananeci adriananeci requested a review from a team as a code owner August 29, 2024 14:15
radu-catalina
radu-catalina previously approved these changes Aug 29, 2024
Copy link

@radu-catalina radu-catalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@aalexandru aalexandru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JonnieDoe
Copy link

/lgtm

@adriananeci adriananeci merged commit 6e23a03 into main Aug 30, 2024
4 checks passed
@adriananeci adriananeci deleted the argo_rollouts branch August 30, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants