Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky e2e test and add support for enabling apiserver debug logs during testing #250

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

adriananeci
Copy link
Contributor

Description

There seems to be a race condition inside the apiserver where k8s-shredder is able to evict pods even if the pdb wouldn't allow soft evictions.

Not sure if it is related to the kind cluster or a real issue inside the apiserver codebase.

This PR adds an extra check to make sure that the PDB status associated with the rollout object is properly populated.

This PR also adds support to enabled apiserver debug logs during trubleshooting by using the ENABLE_APISERVER_DEBUG env var.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@adriananeci adriananeci requested a review from a team as a code owner September 17, 2024 13:28
Copy link

@JonnieDoe JonnieDoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

@itaiatu itaiatu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adriananeci adriananeci merged commit 142074b into main Sep 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants