Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make custom-vars-viewer private #4794

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

rubencarvalho
Copy link
Collaborator

@rubencarvalho rubencarvalho commented Oct 1, 2024

Description

This package was not set to private and making us run into erros while publishing the packages to npm.

Screenshots (if appropriate)

Screenshot 2024-10-01 at 16 12 18

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@Rajdeepc Rajdeepc marked this pull request as ready for review October 1, 2024 14:30
@Rajdeepc Rajdeepc requested a review from a team as a code owner October 1, 2024 14:30
@Rajdeepc Rajdeepc merged commit 5e6f983 into main Oct 1, 2024
10 of 58 checks passed
@Rajdeepc Rajdeepc deleted the ruben/private-custom-css-vars-viewer branch October 1, 2024 14:31
Copy link

github-actions bot commented Oct 1, 2024

Branch preview

Copy link

github-actions bot commented Oct 1, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 228.27 kB 216.557 kB 🏆 216.628 kB
Scripts 57.856 kB 51.941 kB 🏆 51.973 kB
Stylesheet 34.521 kB 30.13 kB 🏆 30.185 kB
Document 6.225 kB 5.463 kB 🏆 5.499 kB
Font 126.843 kB 126.643 kB 126.622 kB 🏆

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

Copy link

github-actions bot commented Oct 1, 2024

Tachometer results

Currently, no packages are changed by this PR...

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11127517619

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.209%

Totals Coverage Status
Change from base Build 11028589290: 0.0%
Covered Lines: 32549
Relevant Lines: 32968

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants