Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated node version #4802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: updated node version #4802

wants to merge 1 commit into from

Conversation

TarunAdobe
Copy link
Contributor

@TarunAdobe TarunAdobe commented Oct 3, 2024

Description

Updated node dependency to 20.13.3

Motivation and context

  • We need to do this cz icons-workflow package needs node version >20
  • Its good to stay up to date :)

How has this been tested?

  • Storybook works fine.
  • Docsite works fine.
  • VRTs are running as expected.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@TarunAdobe TarunAdobe requested a review from a team as a code owner October 3, 2024 11:56
Copy link

github-actions bot commented Oct 3, 2024

Branch preview

Copy link

github-actions bot commented Oct 3, 2024

Tachometer results

Currently, no packages are changed by this PR...

@coveralls
Copy link
Collaborator

coveralls commented Oct 3, 2024

Pull Request Test Coverage Report for Build 11162889370

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.209%

Totals Coverage Status
Change from base Build 11142237379: 0.0%
Covered Lines: 32549
Relevant Lines: 32968

💛 - Coveralls

Copy link

github-actions bot commented Oct 3, 2024

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 229.675 kB 216.694 kB 216.58 kB 🏆
Scripts 59.196 kB 52.026 kB 51.937 kB 🏆
Stylesheet 34.559 kB 30.213 kB 30.17 kB 🏆
Document 6.223 kB 5.458 kB 🏆 5.509 kB
Font 126.845 kB 126.632 kB 126.614 kB 🏆

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

Copy link
Contributor

@Rajdeepc Rajdeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't foresee any breaking changes due to this upgrade but please make sure to run yarn outdated to check for any dependencies not compatible with node v20.
Good to have: You can run an npm audit fix to make sure there are no vulnerabilities detected in any of the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants