Merge pull request #54 from wdcossey/wdcossey/improved-error-message

A more descriptive error message.
adoconnection · May 26, 2021 · 0b1d02d · 0b1d02d
2 parents 3a8ad7f + ef39f88
commit 0b1d02d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/RazorEngineCore/RazorEngine.cs b/RazorEngineCore/RazorEngine.cs
@@ -108,11 +108,9 @@ private MemoryStream CreateAndCompileToStream(string templateSource, RazorEngine
 
             if (!emitResult.Success)
             {
-                List<Diagnostic> errors = emitResult.Diagnostics.ToList();
-
-                RazorEngineCompilationException exception = new RazorEngineCompilationException($"Unable to compile template: {errors.FirstOrDefault()}")
+                RazorEngineCompilationException exception = new RazorEngineCompilationException()
                 {
-                    Errors = errors,
+                    Errors = emitResult.Diagnostics.ToList(),
                     GeneratedCode = razorCSharpDocument.GeneratedCode
                 };
 

diff --git a/RazorEngineCore/RazorEngineCompilationException.cs b/RazorEngineCore/RazorEngineCompilationException.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using System.Runtime.Serialization;
 using Microsoft.CodeAnalysis;
 
@@ -15,15 +16,14 @@ protected RazorEngineCompilationException(SerializationInfo info, StreamingConte
         {
         }
 
-        public RazorEngineCompilationException(string message) : base(message)
-        {
-        }
-
-        public RazorEngineCompilationException(string message, Exception innerException) : base(message, innerException)
+        public RazorEngineCompilationException(Exception innerException) : base(null, innerException)
         {
         }
 
         public List<Diagnostic> Errors { get; set; }
+
         public string GeneratedCode { get; set; }
+
+        public override string Message => $"Unable to compile template: {string.Join("\n", Errors.Where(w => w.IsWarningAsError || w.Severity == DiagnosticSeverity.Error))}";
     }
 }