Fix: Remove ember-classic-decorator package and usage #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gokolo I don't think we can just remove the classic decorator like this. I think we have to instead refactor all the code to use modern Ember things. |
|
This PR was opened awhile ago attempting to update things, if you wanted to try to take it further #814 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading our app to Ember 5.4.0 we encountered errors originating from
ember-light-table's use ofember-classic-decorator. We found that theember-classic-decoratorpackage is not compatible with Ember 5.x.See this Discord thread for more context.
This PR is to remove it from the
ember-light-tableto make it work on Ember 5 projects.Linked issue