[WIP] AEROGEAR-1924 CLI service integration #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleck13
reviewed
Jan 29, 2018
pkg/cmd/integration.go
Outdated
| } | ||
|
|
||
| // exit immediately | ||
| noWait, err := cmd.PersistentFlags().GetBool("no-wait") |
There was a problem hiding this comment.
I think the logic here should go:
if noWait && ! redeploy{
return
}
//wait logic
if redeploy{
//redeploy logic
}
If you want me to assist here I am happy to do so
There was a problem hiding this comment.
What happens if a user specifies no-wait and redeploy? I'm guessing that's not possible so I could just send back the please redeploy message?
There was a problem hiding this comment.
As mentioned on IRC we have to wait if auto redeploy is set. We will document this in the command docs
maleck13
reviewed
Jan 29, 2018
| @@ -107,12 +108,12 @@ func (bc *IntegrationCmd) CreateIntegrationCmd() *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "integration <consuming_service_instance_id> <providing_service_instance_id>", | |||
| Short: "integrate certain mobile services together", | |||
| Long: `example usage: kubectl plugin mobile create integration <consuming_service_instance_id> <providing_service_instance_id> | |||
There was a problem hiding this comment.
I think in the long description we should give an example of how to get the serviceinstance ids
mobile get serviceinstances fh-sync-server
mobile get serviceinstances keycloak
maleck13
reviewed
Jan 29, 2018
pkg/cmd/integration_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func TestIntegrationCmd_GetIntegrationCmd(t *testing.T) { |
There was a problem hiding this comment.
I think we can remove this unless you are intending to fill it in
maleck13
suggested changes
Jan 29, 2018
|
@dimitraz can you rebase pls |
dimitraz
force-pushed
the
AEROGEAR-1924-service-binding
branch
from
e8a18a1
to
e1d5902
Compare
dimitraz
force-pushed
the
AEROGEAR-1924-service-binding
branch
from
e1d5902
to
3c0710e
Compare
|
Closing, see #58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Review existing command for integrating mobile services
Changes proposed in this pull request
--no-waitto exit immediatelyTo do
Which issue this PR fixes (This will close that issue when PR gets merged)
AEROGEAR-1924