Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

fix(packages): Adds GraphQLNonNull to the modelType for ResultList.items #2294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(packages): Adds GraphQLNonNull to the modelType for ResultList.items #2294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/graphback-codegen-schema/src/definitions/schemaDefinitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ export const createModelListResultType = (modelType: GraphQLObjectType) => {
name: `${modelType.name}ResultList`,
fields: {
items: {
type: GraphQLNonNull(GraphQLList(modelType))
type: GraphQLNonNull(GraphQLList(GraphQLNonNull(modelType)))
},
offset: { type: GraphQLInt },
limit: { type: GraphQLInt },
Expand Down
46 changes: 23 additions & 23 deletions packages/graphback-codegen-schema/tests/__snapshots__/GraphQLSchemaCreator.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ type Note {
}

type NoteResultList {
items: [Note]!
items: [Note!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -243,7 +243,7 @@ input StringInput {
}

type NoteResultList {
items: [Note]!
items: [Note!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -274,7 +274,7 @@ enum SortDirectionEnum {
}

type TestResultList {
items: [Test]!
items: [Test!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -325,7 +325,7 @@ input CommentFilter {
}

type CommentResultList {
items: [Comment]!
items: [Comment!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -528,7 +528,7 @@ input ModelWithArrayScalarFilter {
}

type ModelWithArrayScalarResultList {
items: [ModelWithArrayScalar]!
items: [ModelWithArrayScalar!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -560,7 +560,7 @@ input ModelWithTransientFieldFilter {
}

type ModelWithTransientFieldResultList {
items: [ModelWithTransientField]!
items: [ModelWithTransientField!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -657,7 +657,7 @@ input NoteFilter {
}

type NoteResultList {
items: [Note]!
items: [Note!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -749,7 +749,7 @@ input TestFilter {
}

type TestResultList {
items: [Test]!
items: [Test!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -799,7 +799,7 @@ input VersionedFilter {
}

type VersionedResultList {
items: [Versioned]!
items: [Versioned!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -911,7 +911,7 @@ type Test {
scalar GraphbackJSON

type NoteResultList {
items: [Note]!
items: [Note!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -943,7 +943,7 @@ enum SortDirectionEnum {
}

type TestResultList {
items: [Test]!
items: [Test!]!
offset: Int
limit: Int
count: Int
Expand All @@ -958,14 +958,14 @@ input TestFilter {
}

type CommentResultList {
items: [Comment]!
items: [Comment!]!
offset: Int
limit: Int
count: Int
}

type VersionedResultList {
items: [Versioned]!
items: [Versioned!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -1032,7 +1032,7 @@ type ModelWithTransientField {
}

type ModelWithTransientFieldResultList {
items: [ModelWithTransientField]!
items: [ModelWithTransientField!]!
offset: Int
limit: Int
count: Int
Expand All @@ -1053,7 +1053,7 @@ type ModelWithArrayScalar {
}

type ModelWithArrayScalarResultList {
items: [ModelWithArrayScalar]!
items: [ModelWithArrayScalar!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -1430,7 +1430,7 @@ type Test {
scalar GraphbackJSON

type NoteResultList {
items: [Note]!
items: [Note!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -1462,7 +1462,7 @@ enum SortDirectionEnum {
}

type TestResultList {
items: [Test]!
items: [Test!]!
offset: Int
limit: Int
count: Int
Expand All @@ -1477,14 +1477,14 @@ input TestFilter {
}

type CommentResultList {
items: [Comment]!
items: [Comment!]!
offset: Int
limit: Int
count: Int
}

type VersionedResultList {
items: [Versioned]!
items: [Versioned!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -1551,7 +1551,7 @@ type ModelWithTransientField {
}

type ModelWithTransientFieldResultList {
items: [ModelWithTransientField]!
items: [ModelWithTransientField!]!
offset: Int
limit: Int
count: Int
Expand All @@ -1572,7 +1572,7 @@ type ModelWithArrayScalar {
}

type ModelWithArrayScalarResultList {
items: [ModelWithArrayScalar]!
items: [ModelWithArrayScalar!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -1874,7 +1874,7 @@ input CommentFilter {
}

type CommentResultList {
items: [Comment]!
items: [Comment!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -1964,7 +1964,7 @@ input NoteFilter {
}

type NoteResultList {
items: [Note]!
items: [Note!]!
offset: Int
limit: Int
count: Int
Expand Down
8 changes: 4 additions & 4 deletions packages/graphback-datasync/tests/__snapshots__/DataSyncPlugin.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ input CommentFilter {
}

type CommentResultList {
items: [Comment]!
items: [Comment!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -158,7 +158,7 @@ input NoteFilter {
}

type NoteResultList {
items: [Note]!
items: [Note!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -267,7 +267,7 @@ input CommentFilter {
}

type CommentResultList {
items: [Comment]!
items: [Comment!]!
offset: Int
limit: Int
count: Int
Expand Down Expand Up @@ -399,7 +399,7 @@ input CommentFilter {
}

type CommentResultList {
items: [Comment]!
items: [Comment!]!
offset: Int
limit: Int
count: Int
Expand Down
2 changes: 1 addition & 1 deletion packages/graphql-serve/tests/__snapshots__/printSchema.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ input UserFilter {
}

type UserResultList {
items: [User]!
items: [User!]!
offset: Int
limit: Int
count: Int
Expand Down