Add error handling to block statement

aerogearcatalog · Apr 18, 2018 · 8045e01 · 8045e01
1 parent 769399c
commit 8045e01
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 20 deletions.
diff --git a/roles/bind-crc-apb/tasks/main.yml b/roles/bind-crc-apb/tasks/main.yml
@@ -11,18 +11,17 @@
   register: crc_json_config_valid
   ignore_errors: True
 
-- asb_last_operation:
-    description: "config was not valid json. Could not bind"
-  when: crc_json_config_valid.failed
+- block:
+  - asb_last_operation:
+      description: "config was not valid json. Could not bind"
 
-- lineinfile:
-    line: 'config was not valid json. Could not bind'
-    path: '{{ crc_term_msg_filepath }}'
-    unsafe_writes: true
-  when: crc_json_config_valid.failed
+  - lineinfile:
+      line: 'config was not valid json. Could not bind'
+      path: '{{ crc_term_msg_filepath }}'
+      unsafe_writes: true
 
-- fail:
-    msg: "config was not valid json. Could not bind"
+  - fail:
+      msg: "config was not valid json. Could not bind"
   when: crc_json_config_valid.failed
 
 - name: Creating CRC {{ CLIENT_ID }} configmap

diff --git a/roles/provision-crc-apb/tasks/main.yml b/roles/provision-crc-apb/tasks/main.yml
@@ -4,18 +4,17 @@
   register: crc_json_config_valid
   ignore_errors: True
 
-- asb_last_operation:
-    description: "config was not valid json. Could not provision"
-  when: crc_json_config_valid.failed
+- block:
+  - asb_last_operation:
+      description: "config was not valid json. Could not provision"
 
-- lineinfile:
-    line: 'config was not valid json. Could not provision'
-    path: '{{ crc_term_msg_filepath }}'
-    unsafe_writes: true
-  when: crc_json_config_valid.failed
+  - lineinfile:
+      line: 'config was not valid json. Could not provision'
+      path: '{{ crc_term_msg_filepath }}'
+      unsafe_writes: true
 
-- fail:
-    msg: "config was not valid json. Could not provision"
+  - fail:
+      msg: "config was not valid json. Could not provision"
   when: crc_json_config_valid.failed
 
 - name: Creating CRC {{ crc_svc_config_name }} secrets