Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dummy input variables during Scan rewrites #1145

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brandonwillard
Copy link
Member

This PR (potentially) addresses some Scan issues that appear when rewrites use nominal variables too liberally.

At the moment, this is just a draft for testing purposes.

@brandonwillard brandonwillard self-assigned this Aug 24, 2022
@brandonwillard brandonwillard marked this pull request as draft August 24, 2022 06:00
@brandonwillard brandonwillard added bug Something isn't working graph rewriting Scan Involves the `Scan` `Op` important labels Aug 24, 2022
@brandonwillard brandonwillard force-pushed the use-clone_get_equiv-in-Scan-rewrites branch 3 times, most recently from df95224 to 04e2d8a Compare August 24, 2022 06:17
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #1145 (324c564) into main (d7fb940) will increase coverage by 0.00%.
The diff coverage is 45.45%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1145   +/-   ##
=======================================
  Coverage   79.35%   79.35%           
=======================================
  Files         161      161           
  Lines       48260    48262    +2     
  Branches    10955    10955           
=======================================
+ Hits        38295    38297    +2     
  Misses       7453     7453           
  Partials     2512     2512           
Impacted Files Coverage Δ
aesara/scan/op.py 85.48% <0.00%> (ø)
aesara/scan/rewriting.py 79.07% <47.61%> (+0.03%) ⬆️

@brandonwillard brandonwillard force-pushed the use-clone_get_equiv-in-Scan-rewrites branch from 04e2d8a to 324c564 Compare September 1, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working graph rewriting important Scan Involves the `Scan` `Op`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant